Read the time through TimeProvider in GalaxyCloudReader and AppsMenuEntry #179
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#179
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Two classes read the wall clock directly, so no test can move their time.
src/Savepoint.Core/CloudSaves/GalaxyCloudReader.cs,GalaxyCloudReader.SweepLeftovers: comparesDateTime.UtcNowwith a folder's write time to find leftovers. Take aTimeProviderand passBackendOptions.TimefromCoreBackend.GalaxyReader. Breaks.agents/coding-standards/core-injected-side-effects.md.src/Savepoint.App/Platform/AppsMenuEntry.cs,AppsMenuEntry: stamps the hicolor folder withDateTime.UtcNow. Use the clock fromFeatureContext.Clock. Breaks.agents/coding-standards/app-mvvm-view-models.md.Done when
grep -rnE --include=*.cs "DateTime(Offset)?\.(Now|UtcNow)" srcprints nothing, with a test that moves the clock past the leftover age.Shipped in 0.9.17 (PR 227).