Start the Windows file reveal and the mklink test helper with an argument list #178
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#178
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Two places start a process with a joined argument string, which breaks
.agents/coding-standards/csharp-process-argument-list.md.src/Savepoint.App/Features/Settings/SettingsEnvironment.cs,ProcessFileRevealer.Start: the Windows branch buildsArguments = $"/select,\"{path}\"".FileManager.Revealalready passes/select,and the path as two list items; do the same here, or retireProcessFileRevealerin favor ofFileManagerRevealer, which the app already wires. The same method also switches on the strings"windows","macos", and"linux", which breakscsharp-platform-specific-code.md; useOsKind.SettingsScreenViewModelTestsasserts the joined string and changes with the fix.tests/Savepoint.Core.Tests/Services/TempFolder.cs,TempFolder.TryCreateDirectoryLink: formats/c mklink /J ...into one string.TempTree.MakeJunctionshows the list form.Done when the verification search in the process standard prints nothing.
Shipped in 0.9.17 (PR 227).