Start the Windows file reveal and the mklink test helper with an argument list #178

Closed
opened 2026-10-26 17:56:24 -05:00 by ethan-hann · 1 comment
Owner

Two places start a process with a joined argument string, which breaks .agents/coding-standards/csharp-process-argument-list.md.

  • src/Savepoint.App/Features/Settings/SettingsEnvironment.cs, ProcessFileRevealer.Start: the Windows branch builds Arguments = $"/select,\"{path}\"". FileManager.Reveal already passes /select, and the path as two list items; do the same here, or retire ProcessFileRevealer in favor of FileManagerRevealer, which the app already wires. The same method also switches on the strings "windows", "macos", and "linux", which breaks csharp-platform-specific-code.md; use OsKind. SettingsScreenViewModelTests asserts the joined string and changes with the fix.
  • tests/Savepoint.Core.Tests/Services/TempFolder.cs, TempFolder.TryCreateDirectoryLink: formats /c mklink /J ... into one string. TempTree.MakeJunction shows the list form.

Done when the verification search in the process standard prints nothing.

Two places start a process with a joined argument string, which breaks `.agents/coding-standards/csharp-process-argument-list.md`. - `src/Savepoint.App/Features/Settings/SettingsEnvironment.cs`, `ProcessFileRevealer.Start`: the Windows branch builds `Arguments = $"/select,\"{path}\""`. `FileManager.Reveal` already passes `/select,` and the path as two list items; do the same here, or retire `ProcessFileRevealer` in favor of `FileManagerRevealer`, which the app already wires. The same method also switches on the strings `"windows"`, `"macos"`, and `"linux"`, which breaks `csharp-platform-specific-code.md`; use `OsKind`. `SettingsScreenViewModelTests` asserts the joined string and changes with the fix. - `tests/Savepoint.Core.Tests/Services/TempFolder.cs`, `TempFolder.TryCreateDirectoryLink`: formats `/c mklink /J ...` into one string. `TempTree.MakeJunction` shows the list form. Done when the verification search in the process standard prints nothing.
ethan-hann added this to the Code Cleanup milestone 2026-10-26 17:56:24 -05:00
Author
Owner

Shipped in 0.9.17 (PR 227).

Shipped in [0.9.17](https://git.tortal.tech/ethan-hann/SavePoint/releases/tag/v0.9.17) (PR 227).
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#178
No description provided.