Small resilience fixes: fail closed on an unreadable switch journal, log the after-play read failure, notice a git that stopped answering #166

Closed
opened 2026-10-25 23:36:49 -05:00 by ethan-hann · 1 comment
Owner

Found by a resilience review (report kept by the maintainer). (1) GitEngine.Capture.cs:78 treats an unreadable or locked savepoint-switch.json as no journal (SwitchJournal.Read returns null), so a snapshot can record a half-switched folder; refuse whenever the file exists, as the reclaim check at GitEngine.Maintenance.cs:154 does. (2) LaunchOrchestrator.Session.cs:109-113 swallows the exception when reading the folders after play; log it as a warning. (3) GitRunner.cs:108 has no time limit; add a watchdog that logs and tells the player which folder is not answering after 60 s with no progress, without killing a write (D23).

Found by a resilience review (report kept by the maintainer). (1) GitEngine.Capture.cs:78 treats an unreadable or locked savepoint-switch.json as no journal (SwitchJournal.Read returns null), so a snapshot can record a half-switched folder; refuse whenever the file exists, as the reclaim check at GitEngine.Maintenance.cs:154 does. (2) LaunchOrchestrator.Session.cs:109-113 swallows the exception when reading the folders after play; log it as a warning. (3) GitRunner.cs:108 has no time limit; add a watchdog that logs and tells the player which folder is not answering after 60 s with no progress, without killing a write (D23).
ethan-hann added this to the 1.0 milestone 2026-10-25 23:36:49 -05:00
Author
Owner

Shipped in 0.9.15 (pull request 174).

Shipped in 0.9.15 (pull request 174).
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#166
No description provided.