Small resilience fixes: fail closed on an unreadable switch journal, log the after-play read failure, notice a git that stopped answering #166
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#166
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Found by a resilience review (report kept by the maintainer). (1) GitEngine.Capture.cs:78 treats an unreadable or locked savepoint-switch.json as no journal (SwitchJournal.Read returns null), so a snapshot can record a half-switched folder; refuse whenever the file exists, as the reclaim check at GitEngine.Maintenance.cs:154 does. (2) LaunchOrchestrator.Session.cs:109-113 swallows the exception when reading the folders after play; log it as a warning. (3) GitRunner.cs:108 has no time limit; add a watchdog that logs and tells the player which folder is not answering after 60 s with no progress, without killing a write (D23).
Shipped in 0.9.15 (pull request 174).