Do not start git on a game folder while a git from a force-quit SavePoint is still running #165
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#165
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Found by a resilience review (report kept by the maintainer). GitProcessRegistry.cs:21 kills git only on ProcessExit; a Task Manager kill leaves git running, and the startup cleanup (AppStatusApi.cs:450-470) assumes nothing of SavePoint's is running (D18). Fix: at startup, find running processes from the bundled git folder and wait or tell the player before cleaning up; use a kill-on-close job object on Windows and a parent-death signal on Linux.
Shipped in 0.9.15 (pull request 174).