Do not start git on a game folder while a git from a force-quit SavePoint is still running #165

Closed
opened 2026-10-25 23:36:48 -05:00 by ethan-hann · 1 comment
Owner

Found by a resilience review (report kept by the maintainer). GitProcessRegistry.cs:21 kills git only on ProcessExit; a Task Manager kill leaves git running, and the startup cleanup (AppStatusApi.cs:450-470) assumes nothing of SavePoint's is running (D18). Fix: at startup, find running processes from the bundled git folder and wait or tell the player before cleaning up; use a kill-on-close job object on Windows and a parent-death signal on Linux.

Found by a resilience review (report kept by the maintainer). GitProcessRegistry.cs:21 kills git only on ProcessExit; a Task Manager kill leaves git running, and the startup cleanup (AppStatusApi.cs:450-470) assumes nothing of SavePoint's is running (D18). Fix: at startup, find running processes from the bundled git folder and wait or tell the player before cleaning up; use a kill-on-close job object on Windows and a parent-death signal on Linux.
ethan-hann added this to the 1.0 milestone 2026-10-25 23:36:48 -05:00
Author
Owner

Shipped in 0.9.15 (pull request 174).

Shipped in 0.9.15 (pull request 174).
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#165
No description provided.