Screenshot job: after-play.png is not identical between runs #146

Closed
opened 2026-10-25 18:34:02 -05:00 by ethan-hann · 1 comment
Owner

The docs screenshot job (DocScreenshotTests, SAVEPOINT_DOC_SCREENSHOTS=1) is meant to give byte-identical images on every run, but after-play.png changed on a rerun with no change to its screen, most likely the blinking text caret in the dialog's "Name it" field. Freeze or hide the caret (or focus nothing inside the dialog) before drawing, and add a check that two runs give the same bytes for every image.

The docs screenshot job (DocScreenshotTests, SAVEPOINT_DOC_SCREENSHOTS=1) is meant to give byte-identical images on every run, but after-play.png changed on a rerun with no change to its screen, most likely the blinking text caret in the dialog's "Name it" field. Freeze or hide the caret (or focus nothing inside the dialog) before drawing, and add a check that two runs give the same bytes for every image.
ethan-hann added this to the Later milestone 2026-10-25 18:34:02 -05:00
Author
Owner

Shipped in 0.9.13 (pull request 149).

Shipped in 0.9.13 (pull request 149).
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#146
No description provided.