Follow a starter's game on Linux when the starter exits before the first look #145
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#145
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
SavePoint follows the process a short-lived starter hands over to (D13.10, #56) by its parent id. On Linux a process whose parent exits is reparented to init or a subreaper, so when the starter starts the game and exits within one look (2 seconds), the game no longer names the starter and is not followed; Windows keeps the old parent id and follows it. Found when the Linux CI gate failed the real-process test with a starter that exits at once (the test now keeps its starter up with FakeGame's --linger).
A fix could link a process to a gone starter without the parent id: a process that started within the relaunch window after the starter, whose program lies inside the game's install folder, and is not one of the excluded crash reporters. It needs care so an unrelated in-folder process (a second copy of the game, a server the player started) is not taken for the game, for example only when exactly one such process appears.
Shipped in 0.9.13 (pull request 149).