The no-marks index shortcut never fires because repositories use index version 4 #140

Closed
opened 2026-10-25 12:13:03 -05:00 by ethan-hann · 1 comment
Owner

ClearSkipWorktreeAsync skips its ls-files call when the index header says version 2, since only version 3 and up can hold skip-worktree marks. RepoConfigFile sets index.version to 4, so the header is always 4 and every switch, discard and capture still runs the listing. Check the setting first, then either read the extended flags cheaply (a version 4 index still sets a header flag per entry) or drop the shortcut and its tests.

ClearSkipWorktreeAsync skips its ls-files call when the index header says version 2, since only version 3 and up can hold skip-worktree marks. RepoConfigFile sets index.version to 4, so the header is always 4 and every switch, discard and capture still runs the listing. Check the setting first, then either read the extended flags cheaply (a version 4 index still sets a header flag per entry) or drop the shortcut and its tests.
ethan-hann added this to the Later milestone 2026-10-25 12:13:03 -05:00
Author
Owner

Shipped in 0.9.12 (pull request 144).

Shipped in 0.9.12 (pull request 144).
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#140
No description provided.