Cancelling git on macOS can strand its child processes at exit #135
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#135
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
On macOS SavePoint still ends a cancelled git with .NET Process.Kill(entireProcessTree), which stops the root, kills it and then recurses into its children. If SavePoint exits after the root is gone but before the recursion ends, the exit-time kill no longer finds the root and its children (for example pack-objects under a repack) are left running under launchd. Linux now walks /proc and kills the root last, so the exit-time kill always finds the whole tree. Give macOS the same root-last walk (sysctl KERN_PROC or proc_listchildpids) when a Mac is available to test on.