fetch-git.sh still reads git-manifest.json with awk #113
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#113
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The packaging scripts now read
build/msys2-sources.jsonandbuild/git-manifest.jsonthroughtools/PackageSources, so reformatting either file cannot change what they read.build/fetch-git.sh(around lines 70 and 119), which the MSBuild fetch step runs, still parsesgit-manifest.jsonwith awk and depends on its exact layout. Runningdotnet runfrom inside a build is heavier, so decide between a small JSON read that needs no extra tool (for examplepython3if the Linux build already requires it, orjqif it is present), building PackageSources ahead of the fetch, or pinning the layout with a test.