fetch-git.sh still reads git-manifest.json with awk #113

Closed
opened 2026-10-25 00:21:41 -05:00 by ethan-hann · 0 comments
Owner

The packaging scripts now read build/msys2-sources.json and build/git-manifest.json through tools/PackageSources, so reformatting either file cannot change what they read. build/fetch-git.sh (around lines 70 and 119), which the MSBuild fetch step runs, still parses git-manifest.json with awk and depends on its exact layout. Running dotnet run from inside a build is heavier, so decide between a small JSON read that needs no extra tool (for example python3 if the Linux build already requires it, or jq if it is present), building PackageSources ahead of the fetch, or pinning the layout with a test.

The packaging scripts now read `build/msys2-sources.json` and `build/git-manifest.json` through `tools/PackageSources`, so reformatting either file cannot change what they read. `build/fetch-git.sh` (around lines 70 and 119), which the MSBuild fetch step runs, still parses `git-manifest.json` with awk and depends on its exact layout. Running `dotnet run` from inside a build is heavier, so decide between a small JSON read that needs no extra tool (for example `python3` if the Linux build already requires it, or `jq` if it is present), building PackageSources ahead of the fetch, or pinning the layout with a test.
ethan-hann added this to the Later milestone 2026-10-25 00:21:41 -05:00
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#113
No description provided.