Check which profile the after-play dialog and the save list name after a switch #105

Closed
opened 2026-10-24 22:41:35 -05:00 by ethan-hann · 1 comment
Owner

Things an agent noticed while taking user-guide screenshots on 0.9.7 (Ubuntu VM, Grounded with profiles Vanilla, Modded and Heavy mods, Heavy mods made while Vanilla was loaded). None is confirmed yet; reproduce each in a test or on the VM and fix what is wrong:

  1. After playing "Heavy mods", the after-play dialog offered "Replace "Vanilla" with this session" while the Heavy mods row showed Running and New changes.
  2. The saves to load for Heavy mods listed a Vanilla save from 10:14 PM. This may be the intended sharing with the profile it was made from (#87), so check that rule against what was shown.
  3. Rewriting two save files with identical content was reported as "2 files changed". Decide whether same content should count as a change.
  4. After a session was kept, the profile row still said "1 snapshot" until the screen was left and reopened.
Things an agent noticed while taking user-guide screenshots on 0.9.7 (Ubuntu VM, Grounded with profiles Vanilla, Modded and Heavy mods, Heavy mods made while Vanilla was loaded). None is confirmed yet; reproduce each in a test or on the VM and fix what is wrong: 1. After playing "Heavy mods", the after-play dialog offered "Replace \"Vanilla\" with this session" while the Heavy mods row showed Running and New changes. 2. The saves to load for Heavy mods listed a Vanilla save from 10:14 PM. This may be the intended sharing with the profile it was made from (#87), so check that rule against what was shown. 3. Rewriting two save files with identical content was reported as "2 files changed". Decide whether same content should count as a change. 4. After a session was kept, the profile row still said "1 snapshot" until the screen was left and reopened.
ethan-hann added this to the 1.0 milestone 2026-10-24 22:41:35 -05:00
Author
Owner

Investigated on branch issue-105-session-attribution. (1) was a real bug: a profile made with New profile starts its saves on the loaded profile's point, so Replace named the other profile's snapshot; Replace now offers only a snapshot the played profile owns (as History attributes it), and a profile with none gets Keep and Not now. (2) is intended: a profile made from another offers the saves it started with (#87). (3) did not reproduce: SavePoint compares content, and identical bytes with a new time count as unchanged in the engine, the capture count and the launch flow. The likeliest cause on Linux is a mode change (a game or script recreating save files with other permissions), which git counts as a change even with the same bytes; if it shows again, git --git-dir=<storage>/<game>/external.git --work-tree=<saves> diff --raw HEAD will tell, and whether saves folders should ignore permission bits is then a decision to make. (4) did not reproduce in a journey that builds the same state; if it shows again, the log times of the capture job and the profile row reload will say whether a reload ran before the snapshot landed.

Investigated on branch issue-105-session-attribution. (1) was a real bug: a profile made with New profile starts its saves on the loaded profile's point, so Replace named the other profile's snapshot; Replace now offers only a snapshot the played profile owns (as History attributes it), and a profile with none gets Keep and Not now. (2) is intended: a profile made from another offers the saves it started with (#87). (3) did not reproduce: SavePoint compares content, and identical bytes with a new time count as unchanged in the engine, the capture count and the launch flow. The likeliest cause on Linux is a mode change (a game or script recreating save files with other permissions), which git counts as a change even with the same bytes; if it shows again, `git --git-dir=<storage>/<game>/external.git --work-tree=<saves> diff --raw HEAD` will tell, and whether saves folders should ignore permission bits is then a decision to make. (4) did not reproduce in a journey that builds the same state; if it shows again, the log times of the capture job and the profile row reload will say whether a reload ran before the snapshot landed.
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#105
No description provided.